Agent Skills › vllm-project/vime › vime-code-review-preferences

vime-code-review-preferences

GitHub

提供 Vime 代码与文档审查的轻量级启发式规则,涵盖生态描述保护、精简包装函数、优化分支逻辑及抽象设计。

.claude/skills/vime-code-review-preferences/SKILL.md vllm-project/vime

Trigger Scenarios

审查或编辑 Vime 代码时 审查或编辑 Vime 文档时

Install

npx skills add vllm-project/vime --skill vime-code-review-preferences -g -y
More Options

Non-standard path

npx skills add https://github.com/vllm-project/vime/tree/main/.claude/skills/vime-code-review-preferences -g -y

Use without installing

npx skills use vllm-project/vime@vime-code-review-preferences

指定 Agent (Claude Code)

npx skills add vllm-project/vime --skill vime-code-review-preferences -a claude-code -g -y

安装 repo 全部 skill

npx skills add vllm-project/vime --all -g -y

预览 repo 内 skill

npx skills add vllm-project/vime --list

SKILL.md

Frontmatter
{
    "name": "vime-code-review-preferences",
    "description": "Use when reviewing or editing vime code or documentation, especially helper APIs, branch selection, argument validation, and preserving curated README ecosystem project descriptions."
}

Vime Code Review Preferences

Apply these lightweight review heuristics when changing vime code or documentation.

Preserve Ecosystem Project Descriptions

Treat ecosystem listings and third-party project introductions as curated content, including Ecosystem Built on slime in README.md and 基于 slime 构建的生态 in README_zh.md.

  • Unless the user explicitly requests changes to this content, preserve project titles, emojis, wording, descriptive detail, links, ordering, and introductory/concluding prose.
  • Release preparation, code refactors, general README cleanup, and preferences for brevity or consistent style do not authorize shortening, rewriting, standardizing, or reordering these sections.
  • For an explicitly requested addition or correction, edit only the relevant entries and preserve unaffected descriptions in both language versions.

Prefer Direct APIs Over Thin Wrappers

  • Remove helper layers that only rename a call, format one path, or forward arguments without owning meaningful behavior.
  • Prefer calling the concrete reusable API directly, for example a *_to_path helper when the caller already knows the destination path.
  • Keep a wrapper only if it owns a real boundary: compatibility, validation, nontrivial error policy, lifecycle management, metrics/logging semantics, async/retry behavior, or cross-module ownership.
  • Avoid moving a redundant wrapper's body into another file just to preserve the wrapper shape. Inline the simple call at the natural ownership site.
  • When removing a wrapper, search for sibling wrappers and nearby helpers with rg and delete confirmed dead functions in the same pass.
  • Treat single-use convenience functions as suspicious when their only job is path formatting plus forwarding. Prefer the caller owning that one line.

Make Branches Explain Themselves

  • Order conditionals by semantic precedence: special transport/lifecycle modes first, then explicit mode choices, then default paths.
  • Prefer predicates that fully describe the branch, such as mode == "full" and transport == "disk", over a broad predicate followed by an assert that explains what the branch really meant.
  • Use asserts as invariants for impossible states after validation, not as a substitute for clear branch conditions.

Keep Abstractions Honest

  • Add an abstraction only when it removes real duplication, hides fragile mechanics, or clarifies ownership.
  • When a review comment points out repeated indirection, look for a smaller public surface rather than adding another alias.
  • Preserve existing behavior intentionally. If cleanup changes error handling, logging, or failure visibility, call that out in the final response.

Keep Runtime State Out of Args

  • Treat args as configuration. Do not add ad hoc args._xxx attributes to pass actor handles, caches, recovery progress, current versions, or other runtime state between components. Renaming these to public attributes does not fix the ownership problem.
  • Put live state on the component that owns its lifecycle. Pass dependencies explicitly, and use typed return values for startup plans or restoration results shared between components.
  • Avoid replacing scattered temporary fields with a generic args.context bag. Keep each state object's responsibility and lifetime clear.
  • Preserve existing custom hook signatures, call arguments, and return conventions when refactoring internal state. User implementations must not need new parameters merely to accommodate an internal cleanup.

Version History

  • 6845501 Current 2026-11-02 14:34

    新增生态项目描述保护规范,强调保留 README 中的第三方项目介绍;细化运行时状态处理原则,禁止通过参数传递运行时状态。

  • d7e40fe 2026-10-18 22:04
  • 8d1f4cc 2026-07-05 14:58

Same Skill Collection

.claude/skills/add-dynamic-filter/SKILL.md
.claude/skills/add-eval-dataset-config/SKILL.md
.claude/skills/add-reward-function/SKILL.md
.claude/skills/add-rollout-function/SKILL.md
.claude/skills/add-tests-and-ci/SKILL.md
.claude/skills/release/SKILL.md

Metadata

Files
0
Version
6845501
Hash
49a47ab0
Indexed
2026-07-05 14:58

Главная - Вики-сайт
Copyright © 2011-2026 iteam. Current version is 2.156.0. UTC+08:00, 2026-11-07 02:01
浙ICP备14020137号-1