flow-next-spec-completion-review
GitHub验证规范已完成任务是否完全满足要求,用于规范关闭前的合规性检查。根据后端环境执行检测流程,确认实现符合规范而非代码质量审查。
Trigger Scenarios
Install
npx skills add gmickel/flow-next --skill flow-next-spec-completion-review -g -y
SKILL.md
Frontmatter
{
"name": "flow-next-spec-completion-review",
"description": "Verify that a spec's completed tasks fully implement the spec requirements. Use at spec completion before close.",
"user-invocable": false
}
Spec Completion Review Mode
Workflow is backend-split. Read workflow-common.md for Phase 0 (backend detection + philosophy), then read ONLY the file matching your active backend:
BACKEND=codex→ workflow-codex.mdBACKEND=copilot→ workflow-copilot.mdBACKEND=cursor→ workflow-cursor.mdBACKEND=host→ workflow-host.mdBACKEND=rp→ workflow-rp.md
Do not load the others — only the active backend's file is needed.
Verify that the combined implementation of all tasks in a spec satisfies the spec requirements. This is NOT a code quality review (that's impl-review's job) — this confirms spec compliance only.
Role: Spec Completion Review Coordinator (NOT the reviewer)
Backends (branch on the Phase 0 RP_ELIGIBLE probe):
- When
RP_ELIGIBLE=1: RepoPrompt (rp), Codex CLI (codex), GitHub Copilot CLI (copilot), Cursor CLI (cursor), or host-native (host) - When
RP_ELIGIBLE=0: Codex CLI (codex), GitHub Copilot CLI (copilot), Cursor CLI (cursor), or host-native (host) — rp is macOS-only; never list it in guidance you surface (--review=rpstays accepted)
Preamble — execute Phase 0 exactly once
The executable Phase 0 lives in workflow-common.md §"Phase 0: Backend Detection" — Read it and execute it ONCE, before any other bash in this skill. It defines $FLOWCTL (bundled — NOT installed globally; which flowctl fails, expected), probes RP_ELIGIBLE, resolves $BACKEND via the single flowctl review-backend call, and handles the ASK / none cases. Never invoke flowctl review-backend a second time in the same run.
Exception: a --review=<backend> argument (see Backend Selection below) wins — when present, set BACKEND from the flag and skip Phase 0's review-backend call + ASK handling (still run its $FLOWCTL / RP_ELIGIBLE setup lines).
When RP_ELIGIBLE=0 (not macOS, no supported RepoPrompt CLI), never steer the user toward rp: every backend summary, recommendation, or override hint you surface presents only the runnable configured backends codex, copilot, cursor, host (plus none). Suppression is not a ban: an explicit --review=rp, FLOW_REVIEW_BACKEND=rp, or review.backend=rp still resolves to rp and errors at runtime via require_rp_cli().
Backend Selection
Priority (first match wins):
--review=rp|codex|copilot|cursor|host|noneargumentFLOW_REVIEW_BACKENDenv var — bare backend (rp,codex,copilot,cursor,host,none) OR spec form (codex:gpt-5.4:xhigh,copilot:claude-opus-4.5,cursor:gpt-5.5-high);hostis bare-only (host:<model>is rejected).flow/config.json→review.backend(same bare / spec forms)- Error - no auto-detection
Parse from arguments first
Check $ARGUMENTS for:
--review=rpor--review rp→ use rp--review=codexor--review codex→ use codex--review=copilotor--review copilot→ use copilot--review=cursoror--review cursor→ use cursor--review=hostor--review host→ use host--review=noneor--review none→ skip review
If found, use that backend and skip all other detection.
Otherwise: Phase 0 resolves it
No --review flag → $BACKEND comes from workflow-common.md Phase 0 (executed once per the Preamble): the single flowctl review-backend "$SPEC_ID" call with ASK handling included. Do not re-resolve here.
Backend at a glance
The per-backend summary (models, env vars, --spec forms) and the backend[:model[:effort]] spec grammar live in references/backend-at-a-glance.md. Read it only when you surface backend guidance to the user (ASK branch, recommendation, override hint) — routing does not need it.
Critical Rules
Per-backend critical rules live in the backend file you route to (workflow-codex.md, workflow-copilot.md, workflow-cursor.md, workflow-rp.md) — each opens with its own Critical rules section. The host safety invariant and the all-backends rules stay here because they gate routing itself.
For host backend (fn-123 R5 / fn-126):
host is bare-only. After selection, read workflow-host.md.
The review must use a fresh, tool-enforced read-only reviewer from a different
model family and fail closed when no cross-family pin is available.
For all backends:
- If
REVIEW_RECEIPT_PATHset: write receipt after SHIP verdict (RP writes manually after fix loop; codex writes automatically via--receipt) - Any failure → output
<promise>RETRY</promise>and stop. No-verdict transport failures are recorded and their reserved round refunded; never manually reset the review counter. Exit 5 /TRANSPORT_UNHEALTHYstops automatic retries until the backend is repaired.
The three hard invariants (never self-declare SHIP, never mix backends, never skip review silently) live with the shared anti-patterns in workflow-common.md §"Anti-patterns (all backends)".
Input
Arguments: $ARGUMENTS
Format: <spec-id> [--review=rp|codex|copilot|cursor|host|none]
- Spec ID - Required, e.g.
fn-1orfn-22-53k --review- Optional backend override
Workflow
REPO_ROOT="$(git rev-parse --show-toplevel 2>/dev/null || pwd)"
Step 0: Parse Arguments
Parse $ARGUMENTS for:
- First positional arg matching
fn-*→SPEC_ID --review=<backend>→ backend override- Remaining args → focus areas
Step 0.5: Resume terminal status persistence before dispatch
Run this checkpoint after parsing SPEC_ID and before loading or dispatching
any backend. Run the same checkpoint again immediately after host/rp records a
verdict. It recovers a terminal status write that failed after the verdict round
was durably consumed, without reserving or dispatching another review.
This shared step is the sole writer for host and rp terminal status.
if ! TERMINAL_REVIEW_JSON="$($FLOWCTL review-rounds attempts "$SPEC_ID" \
--kind plan --review-type completion --json)" \
|| ! SPEC_STATE_JSON="$($FLOWCTL show "$SPEC_ID" --json)"; then
echo "<promise>RETRY</promise>"
exit 0
fi
LATEST_OUTCOME="$(printf '%s' "$TERMINAL_REVIEW_JSON" \
| jq -r '.attempts[-1].outcome // ""')"
LATEST_SUPERSEDED_BY="$(printf '%s' "$TERMINAL_REVIEW_JSON" \
| jq -r '.attempts[-1].superseded_by // ""')"
VERDICT="$(printf '%s' "$TERMINAL_REVIEW_JSON" \
| jq -r '.attempts[-1].verdict // ""')"
ATTEMPT_BACKEND="$(printf '%s' "$TERMINAL_REVIEW_JSON" \
| jq -r '.attempts[-1].backend // ""')"
ATTEMPT_AT="$(printf '%s' "$TERMINAL_REVIEW_JSON" \
| jq -r '.attempts[-1].timestamp // ""')"
REVIEW_ROUND="$(printf '%s' "$TERMINAL_REVIEW_JSON" \
| jq -r '.review_rounds // 0')"
REVIEW_CAP="$(printf '%s' "$TERMINAL_REVIEW_JSON" \
| jq -r '.review_rounds_cap // 0')"
CURRENT_STATUS="$(printf '%s' "$SPEC_STATE_JSON" \
| jq -r '.completion_review_status // "unknown"')"
CURRENT_REVIEWED_AT="$(printf '%s' "$SPEC_STATE_JSON" \
| jq -r '.completion_reviewed_at // ""')"
TERMINAL_STATUS=""
TERMINAL_EXIT=0
if [[ -n "$LATEST_SUPERSEDED_BY" ]]; then
# A concurrent SHIP superseded this attempt: it reviewed a pre-SHIP artifact,
# charged no round, and must never write a terminal status here.
echo "review superseded by a newer SHIP — durable state unchanged; verdict recorded as evidence only" >&2
echo "COMPLETION_REVIEW_STATUS=$CURRENT_STATUS"
exit 0
fi
if [[ "$LATEST_OUTCOME" == "verdict" && "$VERDICT" == "SHIP" ]]; then
TERMINAL_STATUS="ship"
elif [[ "$LATEST_OUTCOME" == "verdict" \
&& "$VERDICT" == "NEEDS_WORK" \
&& "$REVIEW_CAP" -gt 0 \
&& "$REVIEW_ROUND" -ge "$REVIEW_CAP" ]]; then
TERMINAL_STATUS="needs_work"
TERMINAL_EXIT=4
elif [[ "$LATEST_OUTCOME" == "verdict" && "$VERDICT" == "NEEDS_HUMAN" ]]; then
# A reviewer-requested escalation is terminal at any round: persist it here
# and exit, never fall through and reserve another paid round.
TERMINAL_STATUS="needs_human"
TERMINAL_EXIT=4
fi
# A matching status means the terminal already persisted. A newer terminal
# attempt means persistence is pending. A newer completion_reviewed_at is an
# explicit later status decision (for example `unknown` to request re-review);
# honor it instead of resurrecting the old verdict.
if [[ -n "$TERMINAL_STATUS" \
&& ( "$CURRENT_STATUS" == "$TERMINAL_STATUS" \
|| ( -n "$ATTEMPT_AT" \
&& ( -z "$CURRENT_REVIEWED_AT" \
|| "$ATTEMPT_AT" > "$CURRENT_REVIEWED_AT" ) ) ) ]]; then
RECEIPT_PATH="${REVIEW_RECEIPT_PATH:-/tmp/completion-review-receipt-${SPEC_ID}.json}"
RECEIPT_RECOVERY="$REPO_ROOT/.flow/tmp/completion-review-receipt-recovery-${SPEC_ID}.json"
# A recovery payload belongs to exactly one durable attempt. Remove an older
# attempt's artifact before deciding whether this attempt requires a receipt;
# otherwise an optional RP receipt can become spuriously mandatory.
if [[ -f "$RECEIPT_RECOVERY" ]] \
&& ! jq -e --arg id "$SPEC_ID" --arg verdict "$VERDICT" \
--arg mode "$ATTEMPT_BACKEND" --arg attempt_at "$ATTEMPT_AT" \
'.type == "completion_review"
and .id == $id
and .verdict == $verdict
and .mode == $mode
and .attempt_timestamp == $attempt_at' \
"$RECEIPT_RECOVERY" >/dev/null 2>&1; then
if ! rm -f "$RECEIPT_RECOVERY"; then
echo "<promise>RETRY</promise>"
exit 0
fi
fi
RECEIPT_REQUIRED=false
# Bind evidence requirements to the durable attempt being resumed, never
# the backend selected for this invocation (which may have changed).
case "$ATTEMPT_BACKEND" in
codex|copilot|cursor|host) RECEIPT_REQUIRED=true ;;
rp)
[[ "$VERDICT" == "SHIP" \
&& ( -n "${REVIEW_RECEIPT_PATH:-}" || -f "$RECEIPT_RECOVERY" ) ]] \
&& RECEIPT_REQUIRED=true
;;
esac
# Every receipt-owning backend preserves the complete payload here before
# writing the caller-selected path. Restore it before status so a transient
# receipt-path failure never consumes another review or loses Ralph evidence.
if [[ -f "$RECEIPT_RECOVERY" ]]; then
if ! mkdir -p "$(dirname "$RECEIPT_PATH")" \
|| ! cp "$RECEIPT_RECOVERY" "$RECEIPT_PATH"; then
echo "<promise>RETRY</promise>"
exit 0
fi
if ! jq -e --arg id "$SPEC_ID" --arg verdict "$VERDICT" \
--arg mode "$ATTEMPT_BACKEND" --arg attempt_at "$ATTEMPT_AT" \
'.type == "completion_review"
and .id == $id
and .verdict == $verdict
and .mode == $mode
and .attempt_timestamp == $attempt_at' \
"$RECEIPT_PATH" >/dev/null; then
echo "<promise>RETRY</promise>"
exit 0
fi
fi
if [[ "$RECEIPT_REQUIRED" == true ]] \
&& ! jq -e --arg id "$SPEC_ID" --arg verdict "$VERDICT" \
--arg mode "$ATTEMPT_BACKEND" --arg attempt_at "$ATTEMPT_AT" \
'.type == "completion_review"
and .id == $id
and .verdict == $verdict
and .mode == $mode
and .attempt_timestamp == $attempt_at' \
"$RECEIPT_PATH" >/dev/null 2>&1; then
echo "<promise>RETRY</promise>"
exit 0
fi
if [[ "$CURRENT_STATUS" != "$TERMINAL_STATUS" ]]; then
TERMINAL_WRITE_JSON="$($FLOWCTL spec set-completion-review-status "$SPEC_ID" \
--status "$TERMINAL_STATUS" --json)"
TERMINAL_WRITE_EXIT=$?
printf '%s\n' "$TERMINAL_WRITE_JSON"
if [[ "$TERMINAL_WRITE_EXIT" -ne 0 ]]; then
echo "<promise>RETRY</promise>"
exit 0
fi
fi
if ! rm -f "$RECEIPT_RECOVERY"; then
echo "<promise>RETRY</promise>"
exit 0
fi
if [[ "$TERMINAL_EXIT" -eq 4 ]]; then
if [[ "$TERMINAL_STATUS" == "needs_human" ]]; then
echo "ESCALATE: reviewer requested human review"
else
echo "ESCALATE: completion-review did not converge in ${REVIEW_CAP} verdict rounds"
fi
exit 4
fi
echo "VERDICT=SHIP"
exit 0
fi
An exit-4 cap refusal before this run has delivered a completion verdict is
non-terminal for completion status: surface ESCALATE: / NEEDS_HUMAN and do
not invent a needs_work write. More than
${MAX_REVIEW_TRANSPORT_FAILURES:-2} consecutive transport failures stop
separately with TRANSPORT_UNHEALTHY + exit 5; never write completion status or
reset the verdict counter for transport health.
Unchanged-artifact terminal: NOT_RETRYABLE: artifact unchanged since last verdict exits 1 before dispatch. Stop for human action; never refund, reset,
use --force, or redispatch autonomously. A human may edit the exact artifact,
explicitly reset, or deliberately apply --force.
Step 1: Load Backend Workflow
$BACKENDwas already resolved by workflow-common.md Phase 0 (Preamble) — do NOT re-run it.- Read only the file for that backend, per the routing table at the top of this file.
Do not read the other backend files. Each is self-contained for its backend; loading the others wastes context.
Step 2: Execute the backend workflow
Follow the phases in the per-backend file end-to-end. Each file owns its own Identify → Execute → Verdict → Receipt steps (and, for RP, the full Phase 1-4 setup-review (5-15 min, DO NOT RETRY) / chat-send (2-10 min, DO NOT RETRY) / receipt build).
Step 3: Fix loop and terminal status
Both are backend-agnostic and live in workflow-common.md — already in context from Phase 0:
- §"Fix Loop (INTERNAL - do not exit to Ralph)" — the round cap, the anti-patterns, and the parse → fix → commit → re-review cycle.
- §"Record the terminal verdict exactly once" — who writes
completion_review_status, and when host/rp re-run the Step 0.5 checkpoint above.
Version History
- 8baa538 Current 2026-08-20 07:59


