omc-review

GitHub

用于评估已完成工作的缺陷、风险及简化空间,在发布前进行代码审查。通过标准和意图两个维度并行检查正确性、安全性、复用性和覆盖率,确保输出按严重程度排序的详细发现,辅助决策而非强制拦截。

skills/review/SKILL.md Yeachan-Heo/oh-my-claudecode

Trigger Scenarios

代码合并前的质量检查 评估功能或修复的潜在风险与缺陷 验证工作是否符合项目规范与需求

Install

npx skills add Yeachan-Heo/oh-my-claudecode --skill omc-review -g -y
More Options

Use without installing

npx skills use Yeachan-Heo/oh-my-claudecode@omc-review

指定 Agent (Claude Code)

npx skills add Yeachan-Heo/oh-my-claudecode --skill omc-review -a claude-code -g -y

安装 repo 全部 skill

npx skills add Yeachan-Heo/oh-my-claudecode --all -g -y

预览 repo 内 skill

npx skills add Yeachan-Heo/oh-my-claudecode --list

SKILL.md

Frontmatter
{
    "name": "omc-review",
    "description": "Evaluate finished work for defects, risk, and simplification before it ships"
}

Review

Use this skill to evaluate work that already exists. Review never authors the change it is judging.

This is the canonical review workflow. ai-slop-cleaner is an opt-in lane within it.

Goal

Find what is actually wrong, ranked by severity, with enough detail to act on.

Workflow

  1. Establish what changed and what it was meant to do.
  2. Read the change against that intent.
  3. Check correctness first, then risk, then simplification.
  4. Verify each candidate finding before reporting it.
  5. Report findings most-severe first.

What to check

  • Correctness — logic defects, edge cases, error paths, concurrency
  • Risk — security boundaries, destructive operations, data integrity
  • Reuse — existing utilities or patterns the change should have used
  • Simplification — code that could be deleted or collapsed
  • Coverage — behavior that ships untested

Two axes, run apart

A substantial diff is reviewed as two parallel sub-agent passes, reported separately — never merged or cross-ranked, because a change can pass one axis and fail the other (standards-conforming but wrong behavior; faithful but convention-breaking):

  • Standards axis — the diff against the repo's documented standards plus a judgement-call-only smell baseline; anything tooling already enforces is skipped. The standards set is discovered, not assumed: search the repo for standards documents (CLAUDE.md/AGENTS.md, docs/standards/ volumes, CONTRIBUTING.md, CODING_STANDARDS.md or equivalents) and review against whatever exists — a standards file you didn't look for is a standard you didn't apply.
  • Intent axis — the diff against what the work was meant to do — the task, spec, or ticket acceptance criteria: requirements missing or partial, behavior nobody asked for, each finding quoting its source line.

Keep each sub-agent brief under ~400 words and pointed at one axis. Aggregate without picking a single winner across axes — that reranking is what the separation exists to prevent; state each axis's verdict on its own. A small diff stays one pass.

Rules

  • Separate lanes: the reviewer must not be the author's same active context.
  • Verify before reporting. A plausible-sounding finding that does not reproduce is noise.
  • State severity honestly; do not pad the list to look thorough.
  • "No findings" is a valid result when the work is sound.
  • Advisory by default — review informs, it does not gate. Hard gates (release, security, destructive operations) stay separate and fail closed.

Output

  • Findings, most-severe first, each with file, line, and concrete failure scenario
  • What was checked and found clean
  • Anything that could not be assessed

Quality Gates

Before finalizing the review, check the existing merged OMC qualityGates["omc-review"] entries (project stage entries replace the user list; see docs/quality-gates-configuration.md). If there are no entries, do not call omc quality-gates list, spawn gate tasks, or add a Quality Gates section or gate records to the review output. If there is at least one entry, call omc quality-gates list --stage omc-review --json and show every validation error. For each available gate, spawn one independent Claude Code Task that loads the named skill from resolvedPath, reviews the same changes, and returns VERDICT: PASS or VERDICT: BLOCK plus findings. Use the configured model override when present; do not pass another reviewer's output to the gate. Reuse the same gate lane if the change is revised and reviewed again.

When gates are configured, record { gate, mode, verdict } for each gate in a Quality Gates section of the review output. Unresolved skills are gate_unavailable with a visible warning, never PASS; they do not fail the review stage. A blocking BLOCK makes the overall result REQUEST CHANGES; advisory results are informational and never block.

Version History

  • 14cd0fe Current 2026-11-03 01:30

    新增对现有 OMC 质量门禁(qualityGates)配置的集成支持,允许通过配置化阶段控制器控制审查流程,替代硬编码逻辑。

  • 6688a30 2026-10-19 08:28

    移除已废弃的 merge-readiness 工具引用;新增‘标准轴’审查机制,要求自动发现仓库中的标准文档而非硬编码列表,并引入‘意图轴’对比实际行为与需求一致性。

  • 74e4e11 2026-08-28 11:12

Same Skill Collection

skills/agent-doc-discipline/SKILL.md
skills/ai-slop-cleaner/SKILL.md
skills/architecture-survey/SKILL.md
skills/ask-navigator/SKILL.md
skills/ask/SKILL.md
skills/autopilot/SKILL.md
skills/autoresearch/SKILL.md
skills/cancel/SKILL.md
skills/ccg/SKILL.md
skills/configure-notifications/SKILL.md
skills/debug/SKILL.md
skills/deep-dive/SKILL.md
skills/deep-interview/SKILL.md
skills/deepinit/SKILL.md
skills/diagram/SKILL.md
skills/drydock/SKILL.md
skills/execute/SKILL.md
skills/external-context/SKILL.md
skills/graph/SKILL.md
skills/harbor/SKILL.md
skills/hud/SKILL.md
skills/intent/SKILL.md
skills/learner/SKILL.md
skills/local-build-reminder/SKILL.md
skills/loft/SKILL.md
skills/map/SKILL.md
skills/mcp-setup/SKILL.md
skills/merge-readiness/SKILL.md
skills/minimal-code-discipline/SKILL.md
skills/minimal-prose-discipline/SKILL.md
skills/omc-doctor/SKILL.md
skills/omc-reference/SKILL.md
skills/omc-setup/SKILL.md
skills/omc-teams/SKILL.md
skills/plan/SKILL.md
skills/pr/SKILL.md
skills/project-session-manager/SKILL.md
skills/ralph/SKILL.md
skills/ralplan/SKILL.md
skills/refit/SKILL.md
skills/release/SKILL.md
skills/remember/SKILL.md
skills/research/SKILL.md
skills/sciomc/SKILL.md
skills/self-improve/SKILL.md
skills/session-flow/SKILL.md
skills/setup/SKILL.md
skills/skill/SKILL.md
skills/skillify/SKILL.md

Metadata

Files
0
Version
14cd0fe
Hash
af358461
Indexed
2026-08-28 11:12

trang chủ - Wiki
Copyright © 2011-2026 iteam. Current version is 2.155.2. UTC+08:00, 2026-11-05 05:10
浙ICP备14020137号-1