Agent Skills › glommer/pgmicro › code-quality

code-quality

GitHub

提供代码质量指导，涵盖正确性、Rust模式、注释规范及防过度设计。强调生产级正确性，禁止静默失败，主张用断言或错误处理替代无效分支，遵循SQLite索引顺序，并清理无用代码。

.claude/skills/code-quality/SKILL.md glommer/pgmicro

Trigger Scenarios

编写或重构Rust代码时审查代码正确性与风格时需要添加注释或处理异常状态时

Install

npx skills add glommer/pgmicro --skill code-quality -g -y

More Options

Non-standard path

npx skills add https://github.com/glommer/pgmicro/tree/master/.claude/skills/code-quality -g -y

Use without installing

npx skills use glommer/pgmicro@code-quality

指定 Agent (Claude Code)

npx skills add glommer/pgmicro --skill code-quality -a claude-code -g -y

安装 repo 全部 skill

npx skills add glommer/pgmicro --all -g -y

预览 repo 内 skill

npx skills add glommer/pgmicro --list

SKILL.md

Frontmatter

{
    "name": "code-quality",
    "description": "General Correctness rules, Rust patterns, comments, avoiding over-engineering. When writing code always take these into account"
}

Code Quality Guide

Core Principle

Production database. Correctness paramount. Crash > corrupt.

Correctness Rules

No workarounds or quick hacks. Handle all errors, check invariants
Assert often. Never silently fail or swallow edge cases
Crash on invalid state if it risks data integrity. Don't continue in undefined state
Consider edge cases. On long enough timeline, all possible bugs will happen

Rust Patterns

Make illegal states unrepresentable
Exhaustive pattern matching
Prefer enums over strings/sentinels
Minimize heap allocations
Write CPU-friendly code (microsecond = long time)

If-Statements

Wrong:

if condition {
    // happy path
} else {
    // "shouldn't happen" - silently ignored
}

Right:

// If only one branch should ever be hit:
assert!(condition, "invariant violated: ...");
// OR
return Err(LimboError::InternalError("unexpected state".into()));
// OR
unreachable!("impossible state: ...");

Use if-statements only when both branches are expected paths.

Comments

Do:

Document WHY, not what
Document functions, structs, enums, variants
Focus on why something is necessary

Don't:

Comments that repeat code
References to AI conversations ("This test should trigger the bug")
Temporal markers ("added", "existing code", "Phase 1")

Avoid Over-Engineering

Only changes directly requested or clearly necessary
Don't add features beyond what's asked
Don't add docstrings/comments to unchanged code
Don't add error handling for impossible scenarios
Don't create abstractions for one-time operations
Three similar lines > premature abstraction

Index Mutations

When code involves index inserts, deletes, or conflict resolution, double-check the ordering against SQLite. Wrong ordering causes index inconsistencies. and easy to miss.