Agent Skills › simstudioai/sim › emcn-design-review

emcn-design-review

GitHub

审查UI代码是否符合emcn设计系统规范,包括组件、Token及约定。支持指定范围并自动修复违规项或仅提出建议。

.agents/skills/emcn-design-review/SKILL.md simstudioai/sim

触发场景

需要检查UI代码与设计系统一致性时 执行前端代码审查或重构时

安装

npx skills add simstudioai/sim --skill emcn-design-review -g -y
更多选项

非标准路径

npx skills add https://github.com/simstudioai/sim/tree/main/.agents/skills/emcn-design-review -g -y

不安装直接使用

npx skills use simstudioai/sim@emcn-design-review

指定 Agent (Claude Code)

npx skills add simstudioai/sim --skill emcn-design-review -a claude-code -g -y

安装 repo 全部 skill

npx skills add simstudioai/sim --all -g -y

预览 repo 内 skill

npx skills add simstudioai/sim --list

SKILL.md

Frontmatter
{
    "name": "emcn-design-review",
    "description": "Review UI code for alignment with the emcn design system — components, tokens, patterns, and conventions",
    "argument-hint": "[scope] [fix=true|false]"
}

EMCN Design Review

Arguments:

  • scope: what to review (default: your current changes). Examples: "diff to staging", "PR #123", "src/components/", "whole codebase"
  • fix: whether to apply fixes (default: true). Set to false to only propose changes.

User arguments: $ARGUMENTS

Context

This codebase uses emcn, a custom component library built on Radix UI primitives with CVA variants and CSS variable design tokens. All UI must use emcn components and tokens.

Steps

  1. Read the emcn public barrel at packages/emcn/src/index.ts (re-exports components, Calendar, Table*, and icons) to know what's available; for the full icon set read packages/emcn/src/icons/index.ts
  2. Read apps/sim/app/_styles/globals.css for CSS variable tokens
  3. Analyze the specified scope against every rule below
  4. If fix=true, apply the fixes. If fix=false, propose the fixes without applying.

Imports

  • Components, cn, and tokens from the @sim/emcn barrel, never component subpaths
  • Icons from @sim/emcn/icons

Design Tokens

Use CSS variable pattern (text-[var(--text-body)]), never Tailwind semantics (text-muted-foreground) or hardcoded colors (text-gray-500, #333).

Text: --text-primary, --text-secondary, --text-tertiary, --text-muted, --text-body (canonical value text), --text-icon, --text-placeholder, --text-subtle, --text-inverse, --text-error Surfaces: --bg, --surface-1 through --surface-7, --surface-hover, --surface-active Borders: --border (--border-1/--border-muted are legacy aliases resolving to it — flag new uses) Brand/accent: --brand-secondary, --brand-accent Z-Index: --z-dropdown (100), --z-toast (150), --z-modal (200), --z-popover (300), --z-tooltip (400), --z-takeover (500), --z-shell-gate (600) Shadows: shadow-subtle, shadow-medium, shadow-overlay, shadow-card Badges: --badge-* semantic families (success/error/gray/blue/purple/orange/amber/teal/cyan/pink, each with -bg/-text)

Buttons and chips

Header/action chrome is Chip/ChipLink (variants primary, destructive, outline, border, border-shadow; omit variant for the bare chip, and filled is reserved for chip fields and triggers). Selection and toggles use the active prop, never a variant. A single-resource Delete is a plain chip behind ChipConfirmModal; destructive is only for at-scale actions (.claude/rules/sim-settings-pages.md "Deleting a resource"). Button is only for icon-only toolbar controls (ghost/quiet, size='icon').

Delete/Remove Confirmations

Use ChipConfirmModal (title "Delete/Remove {ItemType}", confirm={{ label, onClick }}, which defaults to destructive). Keep its fail-safe defaultAction='dismiss' per .claude/rules/emcn-components.md "Modal keyboard defaults". Put irreversible-consequence copy in text.

Toast

toast.success(), toast.error(), toast() from @sim/emcn. Never custom notification UI.

Badges

red=error/failed, gray-secondary=metadata/roles, type=type annotations, green=success/active, gray=neutral, amber=processing, orange=paused, blue=info. Use dot prop for status indicators.

Icons

Default: size-[14px]. Color: text-[var(--text-icon)]. Scale: 14px > 16px > 12px > 20px. Use the size-* shorthand — flag h-[Npx] w-[Npx] and h-N w-N pairs as refactor targets.

Mobile

Check at 320px and 390px with touch, then desktop and fullscreen. Use Chip/ChipLink's mobileIconOnly for familiar mobile toolbar actions, preserving accessible names; keep labels for ambiguous choices. Keep navigation, primary actions, and dismissal reachable without hover or dragging; aim for 44px touch targets with compact visible icons/button faces and 16px editable text. Match behavior to the actual container or viewport breakpoint. Contain horizontal scrolling to intentional tables/code, fit overlays to the dynamic viewport, and keep the composer/actions reachable with the keyboard open. Reuse EMCN tokens and brief motion with reduced-motion support; preserve desktop geometry.

Anti-patterns to flag

  • Raw <button>/<input>, or legacy Input/Textarea/Modal, instead of the canonical chip components (ChipInput/ChipTextarea/ChipModal)
  • Hand-rolled field rows inside a ChipModalBody instead of ChipModalField
  • Hardcoded colors (text-gray-*, #hex, rgb())
  • Tailwind semantics (text-muted-foreground) instead of CSS variables
  • Template literal className instead of cn()
  • Inline styles for colors/static values (dynamic values OK)
  • Importing from emcn subpaths instead of barrel
  • Arbitrary z-index instead of tokens
  • Wrong button variant for action type

版本历史

  • c6cef5f 当前 2026-10-20 02:38

    更新Chip变体说明,修正Token示例语法,对齐Agent指导与代码规范。

  • 6dfb467 2026-09-23 06:36

    修正导入路径为@sim/emcn barrel,移除冗余过时模式。

  • ceda457 2026-08-20 15:29

同 Skill 集合

.agents/skills/add-block-preview/SKILL.md
.agents/skills/add-block/SKILL.md
.agents/skills/add-column-type/SKILL.md
.agents/skills/add-connector/SKILL.md
.agents/skills/add-enrichment/SKILL.md
.agents/skills/add-feature-flag/SKILL.md
.agents/skills/add-hosted-key/SKILL.md
.agents/skills/add-integration/SKILL.md
.agents/skills/add-managed-cli/SKILL.md
.agents/skills/add-model/SKILL.md
.agents/skills/add-permission-group-item/SKILL.md
.agents/skills/add-selector/SKILL.md
.agents/skills/add-settings-page/SKILL.md
.agents/skills/add-tools/SKILL.md
.agents/skills/add-trigger/SKILL.md
.agents/skills/babysit/SKILL.md
.agents/skills/cleanup/SKILL.md
.agents/skills/council/SKILL.md
.agents/skills/db-migrate/SKILL.md
.agents/skills/design-taste-frontend/SKILL.md
.agents/skills/emil-design-eng/SKILL.md
.agents/skills/make-interfaces-feel-better/SKILL.md
.agents/skills/memory-load-check/SKILL.md
.agents/skills/react-query-best-practices/SKILL.md
.agents/skills/ship/SKILL.md
.agents/skills/test-audit/SKILL.md
.agents/skills/tool-registry-boundary/SKILL.md
.agents/skills/v2-api-conventions/SKILL.md
.agents/skills/validate-connector/SKILL.md
.agents/skills/validate-integration/SKILL.md
.agents/skills/validate-model/SKILL.md
.agents/skills/validate-permission-group-item/SKILL.md
.agents/skills/validate-selector/SKILL.md
.agents/skills/validate-trigger/SKILL.md
.agents/skills/you-might-not-need-a-callback/SKILL.md
.agents/skills/you-might-not-need-a-comment/SKILL.md
.agents/skills/you-might-not-need-a-memo/SKILL.md
.agents/skills/you-might-not-need-an-effect/SKILL.md
.agents/skills/you-might-not-need-state/SKILL.md
.agents/skills/you-might-not-need-url-state/SKILL.md
.claude/skills/add-settings-page/SKILL.md
helm/sim/.claude/skills/sim-helm/SKILL.md
.agents/skills/migrate-application-operation/SKILL.md

元信息

文件数
0
版本
c6cef5f
Hash
da4765ff
收录时间
2026-08-20 15:29

首页 - Wiki
Copyright © 2011-2026 iteam. Current version is 2.156.0. UTC+08:00, 2026-11-21 16:27
浙ICP备14020137号-1