/audit Skill — In-Session Code Review

This skill is the in-session execution path for /audit, where Claude Code is the LLM. It is used when --local is passed, or when no external model is configured. For the orchestrator path (libexec/raptor-audit run with an external LLM), see .claude/commands/audit.md.

[CONFIG]

• Model: Opus for all code review. Sonnet for orchestration plumbing only.
• Unit of review: directory (subsystem), not individual function.
• Context slice: function source + 1-hop callers + 1-hop callees + checklist metadata.
• Checklist item fields: name, kind ("function"/"global"/"macro"/"class"), line_start, line_end, signature, checked_by, metadata (visibility, params, return_type, attributes). The field is kind, not type. Source: core/inventory/extractors.CodeItem.
• Findings format: standard findings.json (same as /scan, fed to /validate unchanged).
• Review record: journal entries in review-journal.jsonl, written via raptor-audit record. (Per-function markdown annotations are the operator's layer — written only via /annotate, never by the LLM.)
• Prerequisite: /understand --map must have run first. If context-map.json is missing from the output directory (or project siblings), run it before starting the review loop — load and follow .claude/skills/code-understanding/map.md for the execution steps.
• Scoping: --scope <dir> restricts gap selection to a subdirectory (e.g. ipc/, net/ipv4/). All journal entries and coverage records still write to the project-level output dir, so successive scoped runs accumulate into one audit trail.

[DOMAIN] Study the Codebase Before Auditing

Always study before auditing. You may recognise concepts like RCU, refcounting, or lock ordering from training data — but training data can be stale or incomplete. APIs evolve, locking contracts change between kernel versions, and ownership semantics are codebase-specific. The only way to know your priors are correct is to extract the domain model from the actual source. Without study, you will silently apply stale assumptions and miss bugs whose violation is semantic, not structural.

Before the review loop, run study then map against the target. Follow the execution steps in each skill file — do not guess CLI commands:

1. Study (mandatory): try raptor-study-loop first — it uses the configured LLM model and handles multi-pass iteration automatically. If it fails (no model configured), fall back to the in-session path in .claude/skills/code-understanding/study.md. Produces domain-model.json.
2. Map (mandatory): load and follow .claude/skills/code-understanding/map.md — produces context-map.json (entry points, trust boundaries, sinks)

Both write output to $OUTPUT_DIR so the audit context slice picks them up automatically. Do not start the per-function review loop until both files exist.

Study is iterative — start with a broad path-driven pass over the subsystem, then follow up with targeted concept-driven or multi-identifier passes for specific contracts and paired operations. The skill file documents both execution paths; see [RESUME] for how the right one is chosen automatically.

Three study entry modes:

The + separator in multi-identifier mode triggers correlation — the LLM examines how the identifiers relate to each other (e.g. lock/unlock pairing, get/put refcount symmetry), not just what each one does individually.

[EXEC] Execution Rules

0. No env-var prefixes on commands. NEVER write OUTPUT_DIR=... libexec/raptor-audit ... or VAR=val command. It breaks permission patterns. Capture OUTPUT_DIR from raptor-run-lifecycle start output and pass it via --out flags on every subsequent command.
1. Read code before reasoning. Never describe or hypothesize about code you haven't read with the Read tool.
2. LLM generates hypotheses; tools validate. Never directly classify code as vulnerable — that gets 37% accuracy. Form a hypothesis, generate a mechanical test, run it, evaluate the result.
3. Pure self-critique is prohibited. All iteration MUST include tool feedback. "Review again" without running a tool is forbidden. Generate a new Semgrep rule, CodeQL query, or SMT check instead. Run all tool invocations through libexec/raptor-audit sweep (or the Python API packages.semgrep.runner / packages.coccinelle.runner) — never call semgrep or spatch directly via Bash. This ensures results are logged to the audit trail automatically.
4. Tool evidence is the verdict. If a tool confirms a hypothesis, the finding includes the tool's output as proof. If a tool refutes it, the hypothesis is discarded — no "but I still think..."
5. Journal entries record what was tested, not opinions. Each raptor-audit record entry lists the hypotheses tested, the tools run, and their results. A reviewer can re-run the generated rules to verify. Never write these via /annotate — annotations are human-only.
6. One status per function. Call libexec/raptor-audit record exactly once per reviewed function. Status is clean (no issues), dormant (real bug but currently unreachable/dead code), suspicious (concern but not confirmed), finding (tool-confirmed reachable vulnerability), or error (review blocked). Use dormant — not clean — when a function has a genuine bug that is unreachable today (dead code, no callers, commented out). A dormant bug becomes a finding when reachability changes.
7. Findings need concrete evidence. A finding must cite: the vulnerable code (file:line), what assumption is violated, and the tool output that confirms it. No "this could be dangerous if..."
8. Checker synthesis for patterns. When a confirmed finding suggests a repeatable pattern (e.g., "unchecked return used as index"), generate a codebase-wide Semgrep or Coccinelle rule and run it. One hypothesis → sweep the whole codebase.
9. Run lifecycle. Start with raptor-run-lifecycle start, end with raptor-run-lifecycle complete. On failure: raptor-run-lifecycle fail.
10. Do NOT narrate gate compliance. Only show substantive work — the hypothesis, the tool, the result. No "I am now following EXEC rule 2..."

[GATES] Must-Pass Gates

• G1 [HYPOTHESIS-FIRST]: Every suspicion MUST be framed as a testable hypothesis before any finding is emitted. "X looks dangerous" is not a hypothesis. "If input Y reaches sink Z without check W, CWE-N applies" is.
• G2 [TOOL-GROUNDED]: Every finding MUST have at least one mechanical validation (Semgrep match, CodeQL path, Coccinelle hit, SMT sat result, or compilation test). Ungrounded findings are journal-only (suspicious), never finding.
• G3 [NO-SELF-CRITIQUE-LOOP]: Iteration without tool feedback is prohibited. If re-reviewing, generate a NEW tool invocation.
• G4 [EVIDENCE-IN-JOURNAL]: The journal entry body MUST include tool names and results, not just prose.
• G5 [READ-FIRST]: Code must be read with the Read tool before any hypothesis is formed about it.
• G6 [ASSUMPTION-TRUST]: For every function, identify what it trusts (inputs, return values, global state, caller guarantees) and ask what happens when each trust is violated.
• G7 [REACHABILITY]: Findings must be reachable. The orchestrator chokepoint mechanically enforces this:
  • Two-signal hard gate: zero static callers AND binary oracle absent (full DWARF) → orchestrator refuses finding, forces dormant. The compiler deleted the function — the bug is real but unexploitable.
  • Soft gate: zero static callers, no binary oracle data → orchestrator requires --reach-via explaining how the function is reachable (callback, HTTP route, exported API, cross-language binding, dynamic dispatch). This prevents honeyslop (planted dead code with obvious bugs) from inflating finding counts.
  • Entry points (from context-map) and functions with static callers bypass this gate automatically.

[STYLE]

• Status values in JSON: snake_case (clean, dormant, suspicious, finding, error)
• Status in human output: Title Case (Clean, Suspicious, Finding, Error)
• No red/green indicators (perspective-dependent)
• Journal entry bodies are markdown prose — no JSON in bodies
• Findings in findings.json use standard RAPTOR schema

[STRATEGIES]

Review strategies are selected per-function based on file paths, parameter types, and return types. Multiple strategies can apply to the same function.

Strategy details and CVE exemplars are in .claude/skills/audit/review.md.

[CRITIQUE]

After reviewing a batch of functions, run the tool-grounded critique pass:

libexec/raptor-audit critique --out "$OUTPUT_DIR"

This mechanically identifies:

• Low sweep coverage: functions reviewed with <2 tool checks. Generate additional Semgrep/SMT/CodeQL tests for these.
• Mode 2 gaps: confirmed findings without codebase-wide rules. Write a generalized checker and run it via rules save + rules run.
• Suspicious with untried tools: suspicious functions where not all tool types were attempted. Try the suggested tools.

The critique pass produces action items, not prose. Each item should result in a new sweep call, never just "review again."

[CONTEXT]

The context slice (assembled by raptor-audit context) includes:

• Function source lines with line numbers
• 1-hop callers and callees from the call graph
• Checklist metadata (signature, visibility, parameters, return type, attributes)
• Reachable sinks from context-map.json
• Pre-computed trust surface questions (per-parameter, per-callee)
• Strategy exemplars: per-strategy CVE worked examples showing the reasoning chain that found the bug
• Flow traces: cross-function data flow paths from /understand --trace that pass through this function
• Prior labeled attempts (if available) from the shared corpus
• Existing annotations (for re-review context)

The context is strategy-aware: a function taking (char *buf, size_t len) gets the input handling strategy exemplar (CVE-2023-0179) alongside the general exemplar. Functions in aliasing-relevant code get CVE-2026-31431 (CopyFail).

[REMIND]

• The LLM generates hypotheses and tools; deterministic analysis confirms or refutes.
• 37.6% MORE critical vulnerabilities after 5 iterations of self-refinement without tool feedback (IEEE-ISTAS 2025). Tool grounding is mandatory, not optional.
• A confirmed pattern should always generate a codebase-wide sweep rule (Mode 2 / KNighter pattern).
• Coverage records accumulate across runs. The gap list shrinks each time.
• The review journal persists in the project directory across runs — it's the audit trail. Operator annotations (human-only, via /annotate) persist alongside it.
• After each batch, run critique to find gaps before moving on.

[RESUME] Scaling and Context Management

Automatic path selection

For study, try raptor-study-loop first — it uses an API key to call an external LLM and handles multi-pass iteration automatically. If it fails (no API key configured), fall back to the in-session path in study.md (Claude reads the source directly). No user decision needed — try the automated path, use the fallback silently.

The same principle applies to the review loop: delegate to agents where possible (see below), fall back to direct review for small targets or when agents aren't available.

In-session context management

When running in-session (Claude Code as the LLM), large targets will exhaust context. Three mechanisms manage this:

1. Scope to subsystems

For large codebases, don't audit everything at once. Use --scope to restrict to one subsystem per audit pass:

/audit /data/linux_kernel/linux-6.18.2/ --scope ipc/ --local
/audit /data/linux_kernel/linux-6.18.2/ --scope net/ipv4/ --local

Coverage records accumulate across scoped runs into the same project-level output directory. Each scoped pass is a manageable unit that fits within context and subagent limits.

2. Cross-session resume

On start, check for an existing run before doing study/map again:

libexec/raptor-audit gaps --out "$OUTPUT_DIR"

If gaps exist and domain-model.json + context-map.json are already present, skip study and map — go straight to the review loop. Coverage records, journal entries, and findings from prior sessions are already on disk.

3. Agent delegation

For targets with many files, delegate function reviews to the audit-reviewer agent type to keep the main context slim. Each function review is independent — the context slice packages everything the agent needs.

Group gaps by file (not one agent per function — subagent limits apply). For each file with remaining gaps:

1. Run libexec/raptor-audit context --target "$TARGET" --file <path> --function <name> --out "$OUTPUT_DIR" --json for each function in the file to collect context slices
2. Spawn one audit-reviewer agent per file (via subagent_type: "audit-reviewer"). The prompt must include:
   • OUTPUT_DIR and TARGET paths
   • The file path and list of function names to review
   • Key domain-model context (invariants, contracts relevant to the file)
   • The context slices from step 1
3. The agent has baked-in methodology, CLI syntax, and gates — no need to repeat sweep/record instructions in the prompt

The main loop stays slim: read gaps, group by file, dispatch agents, collect results. Agents can run in parallel for independent files. After each batch completes, run critique to catch weak reviews before continuing.