Agent Skillspydantic/monty › review-general

review-general

GitHub

用于在合并前对代码分支进行全面审查,检查逻辑错误、沙箱逃逸、性能回归及文档一致性等问题。

.agents/skills/review-general/SKILL.md pydantic/monty

Trigger Scenarios

用户请求对当前分支或PR进行合并前审查 需要检查代码中的Bug、安全漏洞或文档缺失

Install

npx skills add pydantic/monty --skill review-general -g -y
More Options

Non-standard path

npx skills add https://github.com/pydantic/monty/tree/main/.agents/skills/review-general -g -y

Use without installing

npx skills use pydantic/monty@review-general

指定 Agent (Claude Code)

npx skills add pydantic/monty --skill review-general -a claude-code -g -y

安装 repo 全部 skill

npx skills add pydantic/monty --all -g -y

预览 repo 内 skill

npx skills add pydantic/monty --list

SKILL.md

Frontmatter
{
    "name": "review-general",
    "description": "Review the current branch against its merge base for bugs, CPython divergence, sandbox escapes, resource-limit escapes, performance regressions, verbose comments and missing .\/limitations\/ or docs\/ updates. Use for a general pre-merge review of a branch or PR."
}

General branch review

git diff --stat origin/main...HEAD   # scope first
git diff origin/main...HEAD

Read the changed files in full — a hunk is rarely enough to judge correctness. Look for:

  • Bugs — logic errors, DropWithContext values not released on every exit path (the fix is defer_drop!/DropGuard, not more drop_with calls), borrow/aliasing mistakes, unhandled error paths.
  • CPython divergence — different results, exception types or messages, missing attributes. Check anything you're unsure of with python-playground.
  • Sandbox escapes — sandboxed code reaching the host filesystem, environment, network or subprocesses.
  • Resource-limit escapes — allocations not charged to the tracker (an unbounded or amplifying String build without StringBuilder), unbounded loops, recursion without a depth guard.
  • Performance — regressions the branch introduces, and improvements you spot.
  • Verbose comments — docstrings and comments should be concise as per CLAUDE.md.
  • Cleanups — duplication, misplaced logic, functions grown too complex.
  • ./limitations/ — a new divergence with no entry is a finding.
  • Docs parity — a user-visible change reflected in only one of README.md, docs/, limitations/ and the crate READMEs is a finding. CLAUDE.md "Documentation surfaces that must stay in sync" has the obligation table. For a full pass, delegate to the docs-parity-reviewer subagent.

Report

Concise, most severe first. Per finding: file:line, what's wrong, the concrete failure it causes. Don't pad with what the branch got right.

Report only, unless the user asks for fixes.

Version History

  • a8ce0a5 Current 2026-08-28 20:47

    新增对文档一致性的审查要求,包括检查README、docs/和limitations/目录的同步情况。

  • 026b383 2026-08-20 09:39

Same Skill Collection

.agents/skills/fastmod/SKILL.md
.agents/skills/fix-pr-comments/SKILL.md
.agents/skills/python-playground/SKILL.md
.agents/skills/review-security/SKILL.md
.agents/skills/review-usability/SKILL.md
.agents/skills/review-verbosity/SKILL.md
.agents/skills/writing-style/SKILL.md

Metadata

Files
0
Version
a8ce0a5
Hash
d0110abe
Indexed
2026-08-20 09:39

Accueil - Wiki
Copyright © 2011-2026 iteam. Current version is 2.155.2. UTC+08:00, 2026-08-29 04:09
浙ICP备14020137号-1 $Carte des visiteurs$